Dash Four wrote:

Tom Eastep wrote:
On 5/10/13 3:42 PM, "Dash Four" <[email protected]> wrote:
init.<distro>.sh in shorewall-init could benefit from including the
above option, but you haven't done it. Any reason?

You mean something like the attached?
Sort of - you need to include the same changes in "stop()" as well. In "setstatedir()" the "firewall" compilation "if" block isn't needed either.
One other thing - your Debian sysv script (ahem!) is not going to work - patch attached.
--- a/Shorewall-init/init.debian.sh
+++ b/Shorewall-init/init.debian.sh
@@ -111,8 +111,8 @@
          # Run in a sub-shell to avoid name collisions
          #
          ( 
-             if ! ${STATE}/$PRODUCT/firewall status > /dev/null 2>&1; then
-                 ${STATE}/$PRODUCT/firewall stop || echo_notdone
+             if ! ${STATEDIR}/$PRODUCT/firewall status > /dev/null 2>&1; then
+                 ${STATEDIR}/$PRODUCT/firewall stop || echo_notdone
              fi
          )
       fi
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel

Reply via email to