On 05/12/2013 08:52 AM, Tom Eastep wrote: > Patch attached. It has uncovered an optimizer bug that is leaving a few > unreferenced chains behind; I'll chase that today.
This patch seems to correct the optimizer. -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________
diff --git a/Shorewall/Perl/Shorewall/Chains.pm b/Shorewall/Perl/Shorewall/Chains.pm
index 35b9b4b..6e626d7 100644
--- a/Shorewall/Perl/Shorewall/Chains.pm
+++ b/Shorewall/Perl/Shorewall/Chains.pm
@@ -1639,8 +1639,8 @@ sub decrement_reference_count( $$ ) {
if ( $toref && $toref->{referenced} ) {
assert($toref->{references}{$chain} > 0 , $toref, $chain );
- delete $toref->{references}{$chain} unless --$toref->{references}{$chain};
- delete_chain( $toref ) unless ( keys %{$toref->{references}} );
+ delete $toref->{references}{$chain} unless --$toref->{references}{$chain};
+ delete_chain_and_references ( $toref ) unless ( keys %{$toref->{references}} );
}
}
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. This 200-page book is written by three acclaimed leaders in the field. The early access version is available now. Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
_______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
