On 10/7/2014 4:01 AM, Tuomo Soini wrote:
> On Mon, 06 Oct 2014 15:57:55 -0700
> Tom Eastep <[email protected]> wrote:
> 
>> RC 1 is now available for testing.
> 
>> Thank you for testing,
> 
> Another problem:
> 
> shorewall save
>    Currently-running Configuration Saved to /var/lib/shorewall/restore
>    WARNING: No ipsets were saved
> 
> Shouldn't give a warning because I don't have ipsets in use...
> 

The attached patch eliminates this warning when SAVE_IPSETS is not set.

Thanks Tuomo,
-Tom
-- 
Tom Eastep        \ When I die, I want to go like my Grandfather who
Shoreline,         \ died peacefully in his sleep. Not screaming like
Washington, USA     \ all of the passengers in his car
http://shorewall.net \________________________________________________
diff --git a/Shorewall/Perl/Shorewall/Chains.pm 
b/Shorewall/Perl/Shorewall/Chains.pm
index bb4b70c..6f252f8 100644
--- a/Shorewall/Perl/Shorewall/Chains.pm
+++ b/Shorewall/Perl/Shorewall/Chains.pm
@@ -8075,9 +8075,12 @@ sub create_save_ipsets() {
                  '' ,
                  "}\n" );
        }
-    } else {
+    } elsif ( $config{SAVE_IPSETS} ) {
        emit( '    error_message "WARNING: No ipsets were saved"',
              "}\n" );
+    } else {
+       emit( '    true',
+             "}\n" );
     }
 }
 

Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel

Reply via email to