On 11/12/2014 7:16 AM, Thomas D. wrote: > Hi, > > in every shorewall service file we have > > EnvironmentFile=-/etc/sysconfig/shorewall > > The "-" before the file makes the file optional, from > http://www.freedesktop.org/software/systemd/man/systemd.exec.html: > >> The argument passed should be an absolute filename or wildcard >> expression, optionally prefixed with "-", which indicates that if the >> file does not exist, it will not be read and no error or warning >> message is logged. This option may be specified more than once in >> which case all specified files are read. If the empty string is >> assigned to this option, the list of file to read is reset, all prior >> assignments have no effect. > > For me it is like using a not initialized variable... something you > normally try to avoid. > > In this special case I don't expect any real problems, however I am > suggesting to remove the "-"... > > What do you think?
There is no uniformity between the distros WRT such a file and the tarball installers don't install one in most cases. So I don't think that we can make the file a requirement unless we actually install it. Also, ATM we don't distribute distro-specific .service files. We would need to do that to take care of the Debian-based distros who use /etc/default rather than /etc/sysconfig for initialization parameter files. -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.clktrk
_______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
