Re: [Shorewall-devel] shorewall-init.service* may call shorewall-init with too many arguments

[Tom Eastep]

On 11/12/2014 8:20 AM, Thomas D. wrote:
> Hi,
> 
> from shorewall-init.service.214:
> 
>> EnvironmentFile=-/etc/sysconfig/shorewall-init
>> ExecStart=/sbin/shorewall-init $OPTIONS start
>> ExecStop=/sbin/shorewall-init $OPTIONS stop
> 
>>From sysconfig file:
> 
>> [...]
>> OPTIONS="-V0"
> 
> Now try
> 
> # shorewall-init -V0 start
> Usage: /sbin/shorewall-init {start|stop}
> # echo $?
> 1
> 
> 
> I think the shorewall-init service file can be simplified:
> 
> --- a/Shorewall-init/shorewall-init.service.214
> +++ b/Shorewall-init/shorewall-init.service.214
> @@ -12,10 +12,9 @@ Conflicts=iptables.service firewalld.service
>  [Service]
>  Type=oneshot
>  RemainAfterExit=yes
> -EnvironmentFile=-/etc/sysconfig/shorewall-init
>  StandardOutput=syslog
> -ExecStart=/sbin/shorewall-init $OPTIONS start
> -ExecStop=/sbin/shorewall-init $OPTIONS stop
> +ExecStart=/sbin/shorewall-init start
> +ExecStop=/sbin/shorewall-init stop
> 
>  [Install]
>  WantedBy=basic.target

Done.

Thanks,
-Tom
-- 
Tom Eastep        \ When I die, I want to go like my Grandfather who
Shoreline,         \ died peacefully in his sleep. Not screaming like
Washington, USA     \ all of the passengers in his car
http://shorewall.net \________________________________________________

signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.clktrk
_______________________________________________
Shorewall-devel mailing list
Shorewall-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shorewall-devel