-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 10/16/2016 12:00 PM, Steven Jan Springl wrote:
> Tom
> 
> The ecn file in the attached config. produces the following error 
> messages:
> 
> Compiling /etc/shorewall90/ecn... ERROR: Internal error in
> Shorewall::Chains::push_matches at
> /usr/share/shorewall/Shorewall/Chains.pm line 1524 at
> /usr/share/shorewall/Shorewall/Config.pm line 1466.
> 
> Shorewall::Config::fatal_error("Internal error in 
> Shorewall::Chains::push_matches at /usr/sha"...) called at
> /usr/share/shorewall/Shorewall/Config.pm line 1506
> 
> Shorewall::Config::assert("") called at
> /usr/share/shorewall/Shorewall/Chains.pm line 1524
> 
> Shorewall::Chains::push_matches(HASH(0xaa05040), 
> "/etc/shorewall90/ecn:11", "p", "tcp", "o", "eth0") called at
> /usr/share/shorewall/Shorewall/Chains.pm line 1583
> 
> Shorewall::Chains::create_irule(HASH(0xa9de7f0), "j", "eth0_ecn", 
> "/etc/shorewall90/ecn:11", "p", "tcp", "o", "eth0") called at
> /usr/share/shorewall/Shorewall/Chains.pm line 2511
> 
> Shorewall::Chains::add_ijump_internal(HASH(0xa9de7f0), "j", 
> HASH(0xaa04de8), 0, "", "/etc/shorewall90/ecn:11", "p", "tcp", "o",
> ...) called at /usr/share/shorewall/Shorewall/Chains.pm line 2527 
> Shorewall::Chains::add_ijump(HASH(0xa9de7f0), "j",
> HASH(0xaa04de8), "/etc/shorewall90/ecn:11", "p", "tcp", "o",
> "eth0") called at /usr/share/shorewall/Shorewall/Misc.pm line 137
> 
> Shorewall::Misc::setup_ecn() called at
> /usr/share/shorewall/Shorewall/Compiler.pm line 846
> 
> Shorewall::Compiler::compiler("script",
> "/var/lib/shorewall/.start", "directory", "/etc/shorewall90",
> "verbosity", 1, "timestamp", 0, "debug", ...) called at
> /usr/share/shorewall/compiler.pl line 142
> 

The attached patch eliminates the problem.

Thanks Steven.

- -Tom
- -- 
Tom Eastep        \ When I die, I want to go like my Grandfather who
Shoreline,         \ died peacefully in his sleep. Not screaming like
Washington, USA     \ all of the passengers in his car
http://shorewall.net \________________________________________________
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: GPGTools - http://gpgtools.org

iQIcBAEBCAAGBQJYA9SFAAoJEJbms/JCOk0QvUkQAMJWjkx7PQpn0C095IPR6l3Q
1blH5TfAHn+hx+tuw3yO8rM1tzzGoIS3mTJFcx2Cuc4Y1II8f8CeQgKzMEcg0m+v
FugyyVt5g/lfBSYlxnbybLkW7acDSPi4rs1oLj1G7mnymwvr4yaUI7rBTKklhuK1
CYRPOERaEEd8KxIIFQgsL7spjqoRS+XfGIJd21+gY4fKqm3Q5jr9K3J6SzFfPyUO
XSA21Y4KDWxBDscWLMJ7I4UhkJ4uVKTGZaqcAbQRVxJXMKEp0Yzm+u8ln2aMSnmC
IXxb9W+ZdAmanMroFxqCoOFU07XHQHJJTeO/FWVzPx7MRCPa9A5JEgSGgDlJJsz1
ZG+fXeyLh2NIXQd4wWWFTRlUGa4MaDC0OxSNZx0AvAR0Y9YtuIu8EofEFhiVcd8g
Rmp8k9+L0C+i9Whi9VFpCsD4CdsnflsdYyMuSo25vE8U7cj97HRfCB9/2Sbcy/BZ
uNhqCo7nxUTZcNo4n39yokCKSA7cvlDxqgUDTiaDjAiWC8iGWECuX8KIVRLZGM6s
+hg9eA3o1LPmv2DrPqPOgfuJoDGpWlVib9sF0eNYc9CiNUVQORA1YDBRKawlU6B/
/poyLdfnv68SNA/IzliKgmMM+842oEpdM5+8Vm35LV9mHuBJT0aiGUixw0dpbcPM
iRXM/mZgqKEdHvxaZfuY
=gFA5
-----END PGP SIGNATURE-----
diff --git a/Shorewall/Perl/Shorewall/Misc.pm b/Shorewall/Perl/Shorewall/Misc.pm
index f3eb03e..8977931 100644
--- a/Shorewall/Perl/Shorewall/Misc.pm
+++ b/Shorewall/Perl/Shorewall/Misc.pm
@@ -134,12 +134,12 @@ sub setup_ecn()
 	    for my $interface ( @interfaces ) {
 		my $chainref = ensure_chain 'mangle', ecn_chain( $interface );
 
-		add_ijump $mangle_table->{POSTROUTING} , j => $chainref, $interfaces{$interface}, p => 'tcp', imatch_dest_dev( $interface ) if have_capability 'MANGLE_FORWARD';
-		add_ijump $mangle_table->{OUTPUT},       j => $chainref, $interfaces{$interface}, p => 'tcp', imatch_dest_dev( $interface );
+		add_ijump_extended $mangle_table->{POSTROUTING} , j => $chainref, $interfaces{$interface}, p => 'tcp', imatch_dest_dev( $interface ) if have_capability 'MANGLE_FORWARD';
+		add_ijump_extended $mangle_table->{OUTPUT},       j => $chainref, $interfaces{$interface}, p => 'tcp', imatch_dest_dev( $interface );
 	    }
 
 	    for my $host ( @hosts ) {
-		add_ijump( $mangle_table->{ecn_chain $host->[0]}, j => 'ECN', $host->[1], targetopts => '--ecn-tcp-remove', p => 'tcp',  imatch_dest_net( $host->[2] ) );
+		add_ijump_extended( $mangle_table->{ecn_chain $host->[0]}, j => 'ECN', $host->[1], targetopts => '--ecn-tcp-remove', p => 'tcp',  imatch_dest_net( $host->[2] ) );
 	    }
 	}
     }
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Shorewall-devel mailing list
Shorewall-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shorewall-devel

Reply via email to