On 10/01/2017 07:36 AM, Matt Darfeuille wrote:
> On 9/30/2017 11:48 PM, Tom Eastep wrote:

> 
> Do you remember what command you used?

I used 'release -pu'.

> My guess is that neither of the '-b' or '-B' options wer given to create
> the tags.
> 
> When I wrote the release script, it could be invoked in 3 ways:
> - Use the -b option.
> - Use the -B option.
> - Create the tags on the current checked out branch.
> 
> Apparently this is not desirable! :)
> To fix that we could do:
> - Require the use of one of the b options.
> - If neither of the -b options are given the script would default to -B
> (automatically detect which branch to use).

I would prefer that. Thanks

> 
> In that case, isn't the else clause superfluous ?
> 

It is still needed to build older 5.x releases.

-Tom

-- 
Tom Eastep        \   Q: What do you get when you cross a mobster with
Shoreline,         \     an international standard?
Washington, USA     \ A: Someone who makes you an offer you can't
http://shorewall.org \   understand
                      \_______________________________________________

Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel

Reply via email to