On 5/13/2018 5:27 AM, Tom Eastep wrote:
> On 5/12/2018 8:25 PM, Matt Darfeuille wrote:
>> On 5/13/2018 2:58 AM, Tom Eastep wrote:
>>> On 05/12/2018 02:39 PM, Matt Darfeuille wrote:
>>>> Signed-off-by: Matt Darfeuille <matd...@gmail.com> ---
>>>> build/release | 4 ++++ 1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/build/release b/build/release index
>>>> b54386c0..6bb7a482 100755 --- a/build/release +++
>>>> b/build/release @@ -307,6 +307,10 @@ elif [ -n
>>>> "$CHECKOUT_BRANCH_NAME" ]; then checkout_branch_func $WEBDIR
>>>> $CHECKOUT_BRANCH_NAME fi
>>>>
>>>> +if ! grep "$VERSION"; then + fatal_error "File
>>>> $WEBDIR/index.html does not contain \"${VERSION}\"." +fi + if [
>>>> -z "$GIT_CODE_OBJECT" -a -z "$GIT_RELEASE_OBJECT" ]; then
>>>> create_tag $GIT create_tag $GITRELEASEDIR
>>>>
>>>
>>> How can the 'grep' command possibly work?
>>>
>
>> If $VERSION is not found in index.html it make no sense to push
>> the master branch of the web repo. So the release script should
>> exit if $VERSION is not found in the file. That is why I'd like to
>> guard about it (note that the script will insure that the master
>> branch is checked out).
>
>> What am I missing?
>
> Nowhere in that command is index.html mentioned...
>
Patch that will correct that sent!
I will "fixup" that when resending for application.
-Matt
--
Matt Darfeuille
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Shorewall-devel mailing list
Shorewall-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shorewall-devel
