> On 10/8/20 3:19 AM, Simon Matter wrote: >> Hi, >> >> It happened recently to me when moving a firewall to a new location... >> >> Before moving I adapted VLAN config and Shorewall configuration. The TC >> config was blindly modified by me to use 'gbit' units. >> >> In the new location nothing seemed to work - you can think of headless >> firewall and headless admin - and I had a hard time to find out that >> changing the TC config from 'mbit' to 'gbit' didn't work. :( >> >> Attached patch against 5.2.8 is my proposal to add support for g,gb,gbit >> and gbps. >> >> From what I saw on my systems is that not all 'tc' versions support >> 'gbit' >> but AFAIK Shorewall always converts the units to 'kbit' for >> compatibility. >> >> Am I right assuming so? >> >> As always, feedback an testing is appreciated. >> > > Thanks, Simon. > > Note that in the Shorewall/code git repository > (https://gitlab.com/shorewall/code), there are no .annotabed sample > files. Those files are created during the build process by combining > each plain config file with its associated manpage. > > Also, the manpages are generated from .xml files; so when modifying a > manpage, the patch must be against the XML file and not the resulting > manpage. > > So you only need to provide patches for Tc.pm, tcinterfaces.xml, > tcdevices.xml and tcclasses.xml.
Thanks Tom, now that you say it I remember there were XLM doc files :-) I'll redo the patch tomorrow. Regards, Simon _______________________________________________ Shorewall-devel mailing list Shorewall-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/shorewall-devel
