OK, ignore this whole thing.  Reapplying the patch to my restored 4.4.22
installation seems to have gone smoothly.  I really don't quite understand
what went wrong on the first try, but it seems fine now...

Sorry for the noise.

-----Original Message-----
From: Andrew Silverman [mailto:[email protected]] 
Sent: Tuesday, August 02, 2011 12:40 PM
To: 'Shorewall Users'
Subject: Re: [Shorewall-users] [PATCH] Nasty bug

Yes, this morning I upgraded the RPMs to the 4.4.22 version using rpm -Uvh
<2 base RPM files> as described in the docs.  This went fine.

I then took the patch from your email, which applied successfully, and a
shorewall6 restart/start produces the errors described.

Note that I have never used the IPv4 shorewall on this system and have not
edited its files previously as I am using only the ipv6 firewall, however
due to the dependencies the ipv4 RPMs are installed.

It's not really that big a deal since I think the bug dealt with in the
patch doesn't apply to my config anyway, and I'll just upgrade to the 22-1
when it's available.  I'll send you the patched file privately as you asked.

-----Original Message-----
From: Tom Eastep [mailto:[email protected]]
Sent: Tuesday, August 02, 2011 12:33 PM
To: Shorewall Users
Subject: Re: [Shorewall-users] [PATCH] Nasty bug

On Tue, 2011-08-02 at 12:16 -0700, Andrew Silverman wrote:
> After applying this patch, Shorewall6 startup fails as follows:
> 
> [root@ipv6tunl Shorewall]# shorewall6 start Compiling...
> Subroutine insert_irule redefined at
/usr/share/shorewall/Shorewall/Rules.pm line 517.
> Subroutine imatch_source_dev redefined at
/usr/share/shorewall/Shorewall/Rules.pm line 2485.
> Global symbol "$comment" requires explicit package name at
/usr/share/shorewall/Shorewall/Rules.pm line 536.
> Global symbol "$comment" requires explicit package name at
/usr/share/shorewall/Shorewall/Rules.pm line 537.
> Global symbol "$iprangematch" requires explicit package name at
/usr/share/shorewall/Shorewall/Rules.pm line 549.
> Global symbol "%capabilities" requires explicit package name at
/usr/share/shorewall/Shorewall/Rules.pm line 1490.
> Compilation failed in require at /usr/share/shorewall/Shorewall/Tunnels.pm
line 31.
> BEGIN failed--compilation aborted at
/usr/share/shorewall/Shorewall/Tunnels.pm line 31.
> Compilation failed in require at
/usr/share/shorewall/Shorewall/Compiler.pm line 32.
> BEGIN failed--compilation aborted at
/usr/share/shorewall/Shorewall/Compiler.pm line 32.
> Compilation failed in require at /usr/share/shorewall/compiler.pl line 44.
> BEGIN failed--compilation aborted at /usr/share/shorewall/compiler.pl line
44.
> [root@ipv6tunl Shorewall]#

Looking back in the recent 'SELinux' thread, you mentioned running 4.4.21.1.
I patched that version of Rules.pm with the patch and it compiles fine.

I really don't see how ALL.patch can generate the above errors. It adds a
single '$' at the end of a regular expression. The errors you are seeing
appear to be caused by mismatched parentheses or braces.

-Tom
-- 
Tom Eastep        \ When I die, I want to go like my Grandfather who
Shoreline,         \ died peacefully in his sleep. Not screaming like
Washington, USA     \ all of the passengers in his car
http://shorewall.net \________________________________________________



----------------------------------------------------------------------------
--
BlackBerry&reg; DevCon Americas, Oct. 18-20, San Francisco, CA The
must-attend event for mobile developers. Connect with experts. 
Get tools for creating Super Apps. See the latest technologies.
Sessions, hands-on labs, demos & much more. Register early & save!
http://p.sf.net/sfu/rim-blackberry-1
_______________________________________________
Shorewall-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-users


------------------------------------------------------------------------------
BlackBerry&reg; DevCon Americas, Oct. 18-20, San Francisco, CA
The must-attend event for mobile developers. Connect with experts. 
Get tools for creating Super Apps. See the latest technologies.
Sessions, hands-on labs, demos & much more. Register early & save!
http://p.sf.net/sfu/rim-blackberry-1
_______________________________________________
Shorewall-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-users

Reply via email to