On 10/8/2013 5:35 AM, Mark van Dijk wrote: > Hi Tom and list members, > > I had the following in my shorewall6 rules file: > > ACCEPT wan lan icmp 135,136 > > to accept ICMPv6 packets of type rtsol/adv. > > When restarting shorewall the following output was observed: > > Undefined subroutine &Shorewall::Chains::list_split called at > /usr/share/shorewall/Shorewall/Chains.pm line 4488, <$currentfile> line 25. > > This is with shorewall6 4.5.19. The most recent is 4.5.21 so apologies > if this is already fixed.
Patch attached. Thanks, -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________
diff --git a/Shorewall/Perl/Shorewall/Chains.pm b/Shorewall/Perl/Shorewall/Chains.pm
index 44ac205..daa0ec5 100644
--- a/Shorewall/Perl/Shorewall/Chains.pm
+++ b/Shorewall/Perl/Shorewall/Chains.pm
@@ -4474,7 +4474,7 @@ sub do_proto( $$$;$ )
fatal_error "An inverted ICMP list may only contain a single type" if $invert;
fatal_error "An ICMP type list is not allowed in this context" if $restricted;
$types = '';
- for my $type ( list_split( $ports, 'ICMP type list' ) ) {
+ for my $type ( split_list( $ports, 'ICMP type list' ) ) {
$types = $types ? join( ',', $types, validate_icmp6( $type ) ) : $type;
}
} else {
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk
_______________________________________________ Shorewall-users mailing list Shorewall-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/shorewall-users
