Hi Thomas,

On 03/13/2016 08:10 AM, Thomas D. wrote:
> Hi,
> 
> I like the new PAGER support added in v5.0.6.
> 
> However, as package maintainer, I am asking myself if I should set this
> to something per default or leave it up to the user.
> 
> For example on Gentoo we have `eselect pager` which will set an
> environment variable "$PAGER".
> 
> Debian/Ubuntu has something similar via `update-alternatives`.
> 
> What about having a special variable like "SYSTEMDEFAULT" which will use
> whatever $PAGER is set to?
> 
> PAGER=              -- No pager
> PAGER=SYSTEMDEFAULT -- Use any $PAGER (can be dynamic! Don't hard code
>                        its current value into the compiled firewall
>                        script)
> PAGER=/usr/bin/less -- User specified a specific pager
> 

The PAGER isn't compiled into the generated script; the script doesn't
produce output requiring a pager. So it is strictly within the CLI that
PAGER is used.

When it comes to default settings, I generally don't change them except
at a major release. As you have noted, another factor is that there is
no uniformity with respect to the default pager implementation among the
distributions. The current Shorewall philosophy is that
distribution-specific settings are in the shorewallrc file. So we could
add a new variable such as DEFAULTPAGER to the shorewallrc file and set
it via the configure[.pl] script(s). Then, shorewall[6].conf could have
PAGER=$DEFAULTPAGER.

The only thing this buys is that installing straight from the tarballs
can produce the same result as installing a distribution maintainer's
package. Not sure if it is worth it.

I'm copying the development list too for opinions on this issue,

-Tom
-- 
Tom Eastep        \ When I die, I want to go like my Grandfather who
Shoreline,         \ died peacefully in his sleep. Not screaming like
Washington, USA     \ all of the passengers in his car
http://shorewall.net \________________________________________________

Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785111&iu=/4140
_______________________________________________
Shorewall-users mailing list
Shorewall-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shorewall-users

Reply via email to