-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 08/03/2016 04:32 AM, Andreas Degert wrote:
> Hi,
> 
> I get an invalid argument error from tc when the handle parameter
> is missing.
> 
> Kernel Debian 4.4.0-0.bpo.1~amd64 iproute2: 4.3.0-1ubuntu3 
> shorewall: 5.0.10.1-1 (current ubuntu yakkety version)
> 

Does the attached patch correct the problem?

        patch /usr/share/shorewall/Shorewall/Tc.pm < FLOW_HANDLE1.patch

Thanks,
- -Tom
- -- 
Tom Eastep        \ When I die, I want to go like my Grandfather who
Shoreline,         \ died peacefully in his sleep. Not screaming like
Washington, USA     \ all of the passengers in his car
http://shorewall.net \________________________________________________
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: GPGTools - http://gpgtools.org

iQIcBAEBCAAGBQJXo13jAAoJEJbms/JCOk0Q/DwQAKsKDUbPJhp+dEGLrylEcmZ+
muJOd3d5ZWFNN73qfBd7chqMpI9ysuzTQBTQJ8H5mmhGomaYFeRHpVPxpSYSlEnZ
Cu/iQTben9tT4T15msCkm/Q2nUCQTthpvSzEBBHM886MerwkBhz002fLd4NYlbM+
S9BNs6Hm7z57hAwVVSZu5t+6Sre3vKdpSv0IZoPoYHP0M4guYezo+GSqpMklRBMr
WtqVMUemnU8wHXQhbMd0fXruCJwJqn1Sm4cmhWb89u/ho/qKS+fCBKI9CvFkldxn
Tfskty0UXiESxTCh0cNt00RuG7/Ktg5Da48jCOJS/oyrZ0EQ0Es8g/MA+49i1L8v
fwWAqTeL9/ad9IJWOv3nV43jvZK0KaP37RbCgOzI6uugHkT9BRnzAWMGrQH/opYe
uHLp6I99PeLNXxijMUK4mWI+yTrYZNRJvs8Nm1NP8d/a8xF+xS87EXwH+yP0zx4X
lIV6qOloGGH7HswtUwxmjgA43S5KudZNX5mqheCcAwVNaoSjfd7ybbm/2ab53BVD
jTJHVqtV1/dm0q+NGa8Hv/NwuoTucAU8PdbeGMzamS+IUDDfyKO1ET51J0uHrKXz
ETOZQTB6QtayBzHI3bsU4yr9VjU6Y8uFcCd8chCFauA6UWZPcSd20UBUy+07ADFn
0J/RnTYGdiTT9JmaMMjl
=1xQr
-----END PGP SIGNATURE-----
diff --git a/Shorewall/Perl/Shorewall/Tc.pm b/Shorewall/Perl/Shorewall/Tc.pm
index 41d1f8c..f87d7f7 100644
--- a/Shorewall/Perl/Shorewall/Tc.pm
+++ b/Shorewall/Perl/Shorewall/Tc.pm
@@ -350,9 +350,10 @@ sub process_simple_device() {
 
     for ( my $i = 1; $i <= 3; $i++ ) {
 	my $prio = 16 | $i;
+	my $j    = $i + 3;
 	emit "run_tc qdisc add dev $physical parent $number:$i handle ${number}${i}: sfq quantum 1875 limit 127 perturb 10";
 	emit "run_tc filter add dev $physical protocol all prio $prio parent $number: handle $i fw classid $number:$i";
-	emit "run_tc filter add dev $physical protocol all prio 1 parent ${number}$i: flow hash keys $type divisor 1024" if $type ne '-' && have_capability 'FLOW_FILTER';
+	emit "run_tc filter add dev $physical protocol all prio 1 parent ${number}$i: handle $j flow hash keys $type divisor 1024" if $type ne '-' && have_capability 'FLOW_FILTER';
 	emit '';
     }
 
------------------------------------------------------------------------------
_______________________________________________
Shorewall-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-users

Reply via email to