-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 06/12/2017 06:19 AM, Vieri Di Paola via Shorewall-users wrote:
> Hi,
>
> I'm trying to install shorewall 5.1.4.1 but got this line repeated
> several times when running shorewall check:
>
> Use of uninitialized value $fanout in concatenation (.) or string
> at /usr/share/shorewall/Shorewall/Rules.pm line 643, <$currentfile>
> line 2.
>
> I had to revert the change quickly so I couldn't really debug this.
> I'll have more time tomorrow, but I was wondering if someone
> already had this issue.
>
That defect was actually introduced in 5.1.0. Patch attached.
patch /usr/share/shorewall/Shorewall/Rules.pm < FANOUT.patch
- -Tom
- --
Tom Eastep \ Q: What do you get when you cross a mobster with
Shoreline, \ an international standard?
Washington, USA \ A: Someone who makes you an offer you can't
http://shorewall.org \ understand
\_______________________________________________
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: GPGTools - http://gpgtools.org
iQIcBAEBCAAGBQJZPqhMAAoJEJbms/JCOk0Q6Q4P/RzSF0Plp2XSIUmCBkxH9ZSz
UF67B01Q1PDONTj8kpkH6a9YiNK2DdR9tlaoerP6H/YnXhBDKRDiZriXtRt5XUy4
ohALDpK1onbwwkGDWMULzAru+vFaiaJxVVk6qixI5GKDRxp1uSnuToXNjJVyOeLS
V8lVNQGIDJrLXcWjjqTf4VMSW0uNvpWbb9Kl7W9t2xYYXt4fO2poz+i/5mPMtVwJ
bntuLsDslKIp1YURwIuabnD8ACXsJw94C/D8zi/7I88vp0nJLj+dAcHuo/I7Kgma
d4ek3Hxd81cpSWOETCNHYG33vrNCCmHYEo1lrc9AL2WtSXUy+c0CkwdYURcquoIW
NTU04iL2JyKrAWAA4tdWXsEi1jr30RlMIHHTGwM/VjyQ0f1JLSwSQUwp8KvLyGzE
VtxkwnGYc/Oe9eJ2C8+JTV/LjeYjJcgfZHhcIWQoXz0ZShMzFVcfdEXM0UQtnvod
xutW4B0w+8sqNHA3COzzRoGUWSOMRpjvhre2J6rahA3VBLa8avxdd4NqbrACxeOh
kTlwNc9PMZJOqfc08jVAf2eFyhx7DiiHFmZmR2X1W7ioS09xWuwDg2K+PdsQdG+c
MtDJuMcgnoY8RvIpzleqOaUt5DdCbsL/ddg6Q9nZKscTMXZE/ld30gaHggahI7ac
Yr20PG5GMcmN5isX6Epy
=jra5
-----END PGP SIGNATURE-----
diff --git a/Shorewall/Perl/Shorewall/Rules.pm b/Shorewall/Perl/Shorewall/Rules.pm
index ee86dc0..629687b 100644
--- a/Shorewall/Perl/Shorewall/Rules.pm
+++ b/Shorewall/Perl/Shorewall/Rules.pm
@@ -617,7 +617,7 @@ sub handle_nfqueue( $$ ) {
fatal_error "Invalid NFQUEUE queue number ($queue1)" unless defined( $queuenum1) && $queuenum1 >= 0 && $queuenum1 <= 65535;
if ( supplied $queue2 ) {
- $fanout = ' --queue-cpu-fanout' if $queue2 =~ s/c$//;
+ $fanout = $queue2 =~ s/c$// ? ' --queue-cpu-fanout' : '';
$queuenum2 = numeric_value( $queue2 );
fatal_error "Invalid NFQUEUE queue number ($queue2)" unless defined( $queuenum2) && $queuenum2 >= 0 && $queuenum2 <= 65535 && $queuenum1 < $queuenum2;
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Shorewall-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-users
