Hey Jens

On Mon, 2016-07-18 at 20:13 +0200, Jens Georg wrote:
> I misunderstood the script. Please check master, no more .gitignore
> in
> git and it should ignore all the things you mentioned below 
cool, it works :)

Just "po/stamp-po" is a generated file missing in the generated
.gitignore list.
There's a rule for po/stamp-it that seems like the best fit to adapt in
git.mk and a much smaller diff than changing the Makefile to generate
po/stamp-it:

> diff --git a/git.mk b/git.mk
> index 9d4bf25..4a8d156 100644
> --- a/git.mk
> +++ b/git.mk
> @@ -228,7 +228,7 @@ $(srcdir)/.gitignore: Makefile.am $(top_srcdir)/git.mk
>                                 po/Makevars.template \
>                                 po/POTFILES \
>                                 po/Rules-quot \
> -                               po/stamp-it \
> +                               po/stamp-po \
>                                 po/.intltool-merge-cache \
>                                 "po/*.gmo" \
>                                 "po/*.header" \

Cheers

> > > 
> > > I've noticed the new make gitignore target from git.mk. How
> > > should
> > > I go
> > > about to add new ignores (e.g. MapWidget.c) - manually or
> > > generate
> > > them
> > > using one of those new targets?
> > 
> > C files should show up automatically IIRC.
> > 
> > > 
> > > Then, I've noticed that after a build there are tons of generated
> > > files
> > > (.page, .m4, .mo, .stamp, ...) that are marked as untracked and
> > > should
> > > probably be listed in .gitignore.
> > > Also, some rules like /*~ or /.*.sw[nop] that would make sense to
> > > be
> > > matched in any subdir (oddly, there is a rule /**/.*.swp). Can we
> > > manually fix up .gitignore without messing up the generation?
> > 
> > Tbh I haven't really understood yet the logic behind that git.mk
> > script.
> > _______________________________________________
> > shotwell-list mailing list
> > [email protected]
> > https://mail.gnome.org/mailman/listinfo/shotwell-list
> _______________________________________________
> shotwell-list mailing list
> [email protected]
> https://mail.gnome.org/mailman/listinfo/shotwell-list

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
shotwell-list mailing list
[email protected]
https://mail.gnome.org/mailman/listinfo/shotwell-list

Reply via email to