On Fri, Sep 23, 2011 at 8:06 AM, Lu Timdale <[email protected]> wrote:
> While it's good to have zoom, red eyes a lot of the time are NOT round due > to eylids. So the tool as is is frustrating to use. Also, it`s annoying > and slow to have to select each eye separately. > > > Currently, the red eye zoom expects to remove the red from the entire area > that is denoted by the circle created with the tool. > > This is incorrect behaviour. > > The red eye tool should be smart enough to only apply the correction to the > area within the denoted circle that is actually RED. This is quite simple > to do. Simply make an irregular mask based on a red filter. Once that is > done, take the original image section corresponding to the new mask (a > subset of the denoted circular section), and correct the redness. This > makes it quite a lot easier to fix all manner of irregular shapes. It > removes any red from a subsection of the image (leaving other valid red > areas... jackets/scarves true). You really only need to define a range of > colour which is considered red to create the irregular mask. > > > This also paves the way to selecting both eyes at the same time, or even > using a square area... it will be irrelevant what the shape the user denotes > since only the red areas within that shape will be modified. All red-eye > tools I have used before did this at least. > > > In addition, this paves the way for enhancing this to autocorrect red-eye > for the entire picture, with one click and not specifying an area at all... > the picture is the area that the algorithm would be applied to. Since this > will possibly cause more collisions with other valid red ares, it would > likely need to be enhanced. You simply need to marry the above to eitherto > > a) face detection to make changes only to anything red on a face > b) shape detection to make changes only to anything resembling a series of > shapes (circular, oval, partially closed bottom, partially closed top, etc.) > Hi Lu, Yes, that would be a huge improvement. Apparently you've brought this issue up in the past since you're mentioned in the ticket: http://redmine.yorba.org/issues/2171 We also have this ticket: http://redmine.yorba.org/issues/549 By the way, we always accept patches for these kinds of things! - Eric _______________________________________________ Shotwell mailing list [email protected] http://lists.yorba.org/cgi-bin/mailman/listinfo/shotwell
