Mike, I do not have the authority to approve your redmine account. However, if you do have the time to work on those defects and you are happy to do so, you can attach patches to the Ubuntu bugs you've opened in Launchpad. Create them using git format-patch. Someone from Yorba will then be able to pick them up and review them before committing them to trunk.
Bruno On 17/09/12 14:50, Mike Dupont wrote: > Ok, well then I have more crashes in the pipeline, > please approve my redmine account and I will report them directly, I > can also fix them when i have time, i have a branch here > https://github.com/h4ck3rm1k3/shotwell > > On Mon, Sep 17, 2012 at 3:42 PM, Bruno Girin <[email protected]> wrote: >> Mike, >> >> We all agree that Shotwell should not crash like that. Thanks for >> reporting the issues. I'll have a look when I can. >> >> Cheers, >> >> Bruno >> >> On 17/09/12 13:50, Mike Dupont wrote: >>> HI, >>> Shotwell works, it works great, >>> just not with invalid data. normally this will never happen, but it >>> happens with you are implementing a new server that looks like piwigo, >>> that might happen once every x years, but shotwell should not crash >>> like that. >>> >>> I returned "OK" from the server not any xml. >>> there is no error checking, >>> lots of shotwell plugins just crash on invalid input. >>> >>> here, I have setup a simple rule in dancer to reproduce the problem : >>> >>> post '/piwigocrash/ws.php' => sub { >>> return "crash"; >>> }; >>> >>> https://github.com/h4ck3rm1k3/photo-librarian-server/commit/fbc6e93ff4fa3d87c671e969b7b3fb6d04955a6b >>> >>> On Mon, Sep 17, 2012 at 11:56 AM, Bruno Girin <[email protected]> wrote: >>>> Hi Mike, >>>> >>>> I thought I had tested that particular scenario. Obviously not. Can you >>>> include the URL that you used so that I can debug? >>>> >>>> Thanks, >>>> >>>> Bruno >>>> >>>> On 17/09/12 10:06, Mike Dupont wrote: >>>>> Package: shotwell >>>>> Version: 0.12.3-2 >>>>> Severity: normal >>>>> >>>>> Dear Maintainer, >>>>> *** Please consider answering these questions, where appropriate *** >>>>> >>>>> * What led up to the situation? >>>>> testing the plugin with a invalid piwigo server api. >>>>> >>>>> * What exactly did you do (or not do) that was effective (or >>>>> ineffective)? >>>>> does not check the response of the server, segfaults. >>>>> >>>>> Entity: line 1: parser error : Start tag expected, '<' not found >>>>> OK >>>>> ^ >>>>> Entity: line 1: parser error : Start tag expected, '<' not found >>>>> OK >>>>> ^ >>>>> ^C >>>>> [1]+ Segmentation fault (core dumped) shotwell (wd: ~) >>>>> >>>>> >>>>> * What was the outcome of this action? >>>>> segfault/hanging program. >>>>> >>>>> * What outcome did you expect instead? >>>>> an error that the response from the server is invalid. >>>>> >>>>> *** End of the template - remove these lines *** >>>>> >>>>> >>>>> -- System Information: >>>>> Debian Release: wheezy/sid >>>>> APT prefers unstable >>>>> APT policy: (500, 'unstable') >>>>> Architecture: i386 (i686) >>>>> >>>>> Kernel: Linux 3.0.0-17-generic-pae >>>>> Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set >>>>> to C) >>>>> Shell: /bin/sh linked to /bin/dash >>>>> >>>>> Versions of packages shotwell depends on: >>>>> ii dbus-x11 1.6.2-2 >>>>> ii libatk1.0-0 2.4.0-2 >>>>> ii libc6 2.13-35 >>>>> ii libcairo-gobject2 1.12.2-2 >>>>> ii libcairo2 1.12.2-2 >>>>> ii libexif12 0.6.20-3 >>>>> ii libexiv2-12 0.23-1 >>>>> ii libgdk-pixbuf2.0-0 2.26.1-1 >>>>> ii libgee2 0.6.4-2 >>>>> ii libgexiv2-1 0.4.1-3 >>>>> ii libglib2.0-0 2.33.12+really2.32.3-1 >>>>> ii libgomp1 4.7.1-9 >>>>> ii libgphoto2-2 2.4.14-2 >>>>> ii libgphoto2-port0 2.4.14-2 >>>>> ii libgstreamer-plugins-base0.10-0 0.10.36-1 >>>>> ii libgstreamer0.10-0 0.10.36-1 >>>>> ii libgtk-3-0 3.4.2-3 >>>>> ii libgudev-1.0-0 175-7 >>>>> ii libjavascriptcoregtk-3.0-0 1.8.1-3.3 >>>>> ii liblcms2-2 2.2+git20110628-2.2 >>>>> ii libpango1.0-0 1.30.0-1 >>>>> ii libraw5 0.14.6-2 >>>>> ii librest-0.7-0 0.7.12-3 >>>>> ii librsvg2-common 2.36.1-1 >>>>> ii libsoup2.4-1 2.38.1-2 >>>>> ii libsqlite3-0 3.7.13-1 >>>>> ii libstdc++6 4.7.1-9 >>>>> ii libunique-3.0-0 3.0.2-1 >>>>> ii libwebkitgtk-3.0-0 1.8.1-3.3 >>>>> ii libx11-6 2:1.5.0-1 >>>>> ii libxml2 2.8.0+dfsg1-5 >>>>> ii shotwell-common 0.12.3-2 >>>>> >>>>> shotwell recommends no packages. >>>>> >>>>> shotwell suggests no packages. >>>>> >>>>> -- no debconf information >>>>> >>>>> >>>> _______________________________________________ >>>> Shotwell mailing list >>>> [email protected] >>>> http://lists.yorba.org/cgi-bin/mailman/listinfo/shotwell >>> > > _______________________________________________ Shotwell mailing list [email protected] http://lists.yorba.org/cgi-bin/mailman/listinfo/shotwell
