On Sun, Nov 22, 2009 at 12:26 PM, Rui Miguel Silva Seabra <r...@1407.org>wrote:
> On Sun, Nov 22, 2009 at 02:12:34AM +0200, Tom Hacohen wrote: > > On Sun, Nov 22, 2009 at 1:33 AM, Rui Miguel Silva Seabra <r...@1407.org > >wrote: > > Looks great :) > > Though a couple of comments > > I think you can (and should) drop the different pages and just put > > everything in the same page. > > All-in-one, ok. no problem. > > > Airplane mode: should probably be an on/off switch that switches all the > > checkboxes to "disabled" and disconnects from all of those networks. > > It does so allready which is why from 1.png to 2.png only wireless > connectivity > was disabled. It was so disabled by toggling off. > > > Network list: should probably not include GSM but GSM should be in a > > different toggle next to airplane mode (or at least distinguished from > the > > rest). > > Maybe add short state description below each checkbox, something that'll > > allow us to write "connecting..."/"failed to connect"/"connected to wifi: > > Toms-house" etc. > > ok. > > > > You should probably take out the "Ringing profile" text out of the combo > box > > and just leave the name of the profile in there, and again, put this in > the > > same page of the rest, everything should be in the same page. > > ok > > > As for the themes changing, it does not belong in this app, it's a job > for > > the "big" settings app, not this "quick" settings app. > > ok. > > > Suspend, lock and poweroff belong to the main page as well. :) > > Other than that, I like the way this is going, I liked the checkboxes > idea > > (looks simple and easy). > > ok. > > > Actually thinking about it, maybe the wifi deserves a place of it's own, > as > > simply clicking a checkbox isn't enough for wifi. Maybe clicking the wifi > > button should pop another tab that's responsible for wifi/gprs > connectivity > > passwords. > > ok, so keep keep two pages, one with all said and done, and one for > wireless > details. > > > concerning [1] cool :) (read my comments above though). > > > > I'm really excited, great job! looking forward to seeing it in shr. > > *blushes* > > Rui > Well, you deserve it. BIG TIME. -- Tom.
_______________________________________________ Shr-devel mailing list Shr-devel@lists.shr-project.org http://lists.shr-project.org/mailman/listinfo/shr-devel
