On Thu, Apr 22, 2010 at 01:12:33AM +0300, Tom Hacohen wrote: > On Thu, Apr 22, 2010 at 12:50 AM, Jens Seidel <[email protected]>wrote: > > > Hi Martin, > > > > thanks a lot for your patch! > > > > Please note that the subject line is much too long. It should be not larger > > than approx. 60 characters (use a proper log message beside the subject to > > explain stuff in more details). > > > It was sent with git's automatic email sending, so it we just git am (apply > mail) to apply it. > It wasn't his choice, it's git whos just taking the commit log and makes the > topic from it.
Not entirely true :). I usually do better multi-line commits than this. But if I expect the message to be short I use -m "message" and then I'm lazy to cut&paste it to $EDITOR when it gets longer or putting '\n's to split it for commit message & body. But sorry for that. > > Also you have to split it into two patches: one > > fixing indentation and one changing the timeout. Clearly I should have split it as it's not about timeout at all :). Again too late I noticed that whole file is almost half/half spaces/tabs and was lazy isolating both changes afterwards. Cheers, -- uin:136542059 jid:[email protected] Jansa Martin sip:[email protected] JaMa _______________________________________________ Shr-devel mailing list [email protected] http://lists.shr-project.org/mailman/listinfo/shr-devel
