Hi Rui,
I've been thinking about the init script / suspend & resume stuff we've
been working on for omnewrotate.
With the current packaged omnewrotate for SHR there is still a problem
with enabling and disabling rotation from the desktop icon.
For me personally I have no issue with the omnewrotate process
persisting through a suspend/resume cycle so I find the suspend/resume
scripts superfluous, though I am aware of one user emailing the list
with an issue. The use of an init script also makes the X startup script
unnecessary as omnewrotate can now be started at boot using the normal
init script systems for this.
As it stands, the desktop icon calls the init script with the "switch"
parameter. This causes start-stop-daemon to check if omnewrotate is
running and either start or stop it. start-stop-daemon uses a pid file
to check whether omnewrotate is running.
As the package in shr currently stands (and the latest in svn), the
scripts for X startup and for suspend and resume are also packaged,
along with the config file for omnewrotate with the value set to
START="yes". This means that you get an omnewrotate process with a
process id (pid) that start-stop-daemon doesn't know about, and
therefore even though omnewrotate is running, the desktop icon is no
longer able to kill it. I see this as quite a serious issue for omnewrotate.
I recommend that the scripts and config file should be removed as per my
git tree, or at the very least the packaged config file should be set to
START="no".
Once that is working we can talk to the person reporting issues with
suspend resume and find a workaround for them that doesn't conflict with
the init system or find their underlying issue. Perhaps rewriting the
desktop (omnewrotate.sh) script to persist the new preferred state to a
file, and have the X-startup / suspend / resume scripts use the init
script to control the process, whilst respecting the persisted state
information. (I can do this given time/evidence).
As it stands the packaged version still behaves badly, so can I persuade
you to make one of the changes above for now to get the packaged version
working, and then we come back to the rest.
Thanks
Tim Abell
_______________________________________________
Shr-devel mailing list
[email protected]
http://lists.shr-project.org/mailman/listinfo/shr-devel
