On 24/05/10 22:34, Emil Brink wrote: > Hi again. > > Here's another patch that adds a sigrok_samplerate_parse() function to > the sigrok library, and uses it from mainwindow.cpp in the GUI to set > the current sample rate before starting capture. > > For me, it pops up the capture dialog and renders a bunch of time > lines and other interesting-looking stuff in the main window.
Hmm... that duplicates a function in sigrok-cli.c called parse_sizestring(). I'd rather you move that one to the backend, if it's needed in the GUI somewhere. libsigrok/output/common.c isn't really the place to put generic backend stuff though -- that entire directory is dedicated to output modules (see the Output API page on the wiki), and common.c just has stuff that all output modules need. Having said that, I don't know if the GUI needs this -- Uwe, can you comment please? -- Bert Vermeulen [email protected] email/xmpp ------------------------------------------------------------------------------ _______________________________________________ sigrok-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sigrok-devel
