Hi, On Sat, May 18, 2013 at 07:16:04AM -0500, Patrick Servello wrote: > Hey everyone, > This is my first time submitting a patch to an open source project, so > please let me know if I am doing anything wrong. > > The error was in output/cvs.c . When writing the column data (not headers) > it started at channel 7 instead of 0. I verified this by comparing > channel/sample data in gtkWave vs excel.
Yup, thanks for the note and the patch. This is fixed now, I merged your patch with some minor changes. The order of probes will become configurable later anyway, both ordering options have pros and cons, but for now it matches the comments again. Note that you can easily make a patch via "git diff > foo.patch" if you modify code in your clone. Even better would be if you commit locally and then create a patch for that commit (which you can send) by doing this: git format-patch HEAD~1 The resulting file will have all the info like date/time, your name/email, etc. etc. which will then appear in the git history. Cheers, Uwe. -- http://hermann-uwe.de | http://sigrok.org http://randomprojects.org | http://unmaintained-free-software.org ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may _______________________________________________ sigrok-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sigrok-devel
