Hello, On Sun, 2 Jun 2013 01:14:02 +0200 Peter Stuge <[email protected]> wrote:
> Paul Sokolovsky wrote: > > check_strutil.c:49:F:sr_samplerate_string:test_khz:0: Invalid > > result for '1.034 kHz': 1.34 kHz. > > check_strutil.c:49:F:sr_samplerate_string:test_mhz:0: Invalid > > result for '1.034567 MHz': 1.34567 MHz. > > check_strutil.c:49:F:sr_samplerate_string:test_ghz:0: Invalid > > result for '441.05 GHz': 441.50000000 GHz. > > > > It's ubuntu 12.04, mostly pristine. > > Is it a known issue or something to look for in my system? > > I've attached a patch (which I haven't tested!) to the bug. It would > be great if you could test it! Thanks for the patch. I tested it, but it still caused the test to fail as some testcases expected no trailing zeroes. Also, as that function apparently destined to format values for UI, trimming zeroes is nice thing. I went to implement that, and then it turned out that other testcases expect trailing zeroes, so I had to patch test after all too. So, it took some refactoring and aux functions, but hopefully all would agree that it made code more readable (and even less relying on common subexpression elimination for efficiency). http://sigrok.org/bugzilla/show_bug.cgi?id=73 Looking at all that, it however raises concern that Sigrok might not support sampling frequencies less than 1Hz. That would be sad. Why floating point wasn't used right away? > //Peter -- Best regards, Paul mailto:[email protected] ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. A cloud service to automate IT design, transition and operations 2. Dashboards that offer high-level views of enterprise services 3. A single system of record for all IT processes http://p.sf.net/sfu/servicenow-d2d-j _______________________________________________ sigrok-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sigrok-devel
