Hi, On Wed, Jul 30, 2014 at 10:28:58AM +0300, Janne Huttunen wrote: > The Brymen BM25x series suports the BC-20X that is an opto-isolated > serial cable. The link seems to be unidirectional i.e. when activated > the DMM periodically sends updates to the host while the host cannot > control the DMM in any way.
Great stuff, merged with a few minor whitespace/typo fixes and such, thanks a lot! I also added your (missing) copyright line to bm25x.c :) One minor thing to check though, we only use the _SER and -ser suffixes in serial-dmm driver names when there are multiple cables/methods to get data from the DMM. This is the case for e.g. the UNI-T UT61D, which can be used with either a USB/HID based cable or with a simple RS232 cable (the drivers are thus named uni-t-ut61d and uni-t-ut61d-ser). If this distinction is not relevant for this Brymen DMM (because there's only one possible cable) we can/should drop the _SER/-ser etc. suffixes. Also, could you please add some info (and photos) about your DMM + cable in our sigrok.org wiki if possible? Ideally there should be a page for the specific DMM you have (which one is it btw?), something like this: http://sigrok.org/wiki/Brymen_BM857 That page should be linked from here (marking the DMM as supported as well): http://sigrok.org/wiki/Supported_hardware In addition we might make a "Brymen BMxxx series" page similar to these eventually (not a priority right now, though): http://sigrok.org/wiki/Rigol_DS2000_series Also, it would be great to have some info and photos of the BC-20X cable, listed here alongside the other Brymen cables: http://sigrok.org/wiki/Device_cables#Brymen_BC-85X.28-1.29 Please let me know which wiki username you prefer, and/or join us on the #sigrok IRC channel on FreeNode to get a wiki account, if you're interested in adding the above content and photos etc. Cheers, Uwe. -- http://hermann-uwe.de | http://randomprojects.org | http://sigrok.org ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ sigrok-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sigrok-devel
