Hi,
On Thu, Aug 07, 2014 at 02:10:23PM +0200, Uffe Jakobsen wrote:
> All sigrok packages are now available as both ports and binary packages
> for FreeBSD.
Great, thanks a lot for working on that!
> Could you please update the sigrok.org/download page - thanks
Done, thanks!
I've had a quick look at the packages, a few quick notes below. Note
that I don't know anything about FreeBSD packaging, so please take this
with a grain of salt.
Items common to multiple packages
---------------------------------
- "MAKE_JOBS_UNSAFE=yes": In case that means that a package doesn't
support parallel builds via e.g. "make -j 4" that should be changed
(since parallel builds should work just fine for all sigrok packages).
- "LICENSE=GPLv3". If that field allows for it, that should be GPLv3+
(GPL, version 3 or later) for libsigrok, libsigrokdecode, sigrok-cli
and PulseView. For libserialport it would be "LGPLv3+", for
sigrok-firmware* see below.
libserialport
-------------
- The description has the usual "The sigrok project aims at..."
description which is wrong for libserialport, though. The libserialport
library is totally independent of anything related to sigrok, it can be
used by various other projects that are not sigrok-related at all. It
just happens to be hosted on sigrok.org, that's all.
Please use the description from the README or wiki:
libserialport is a minimal, cross-platform shared library written
in C that is intended to take care of the OS-specific details when
writing software that uses serial ports.
Also, "WWW: http://sigrok.org/";, please use the full libserialport URL:
"WWW: http://sigrok.org/wiki/Libserialport";
libsigrok
---------
- # Workaround for libusb not knowing LIBUSB_CLASS_APPLICATION
CFLAGS+= -DLIBUSB_CLASS_APPLICATION=0xfe
This should no longer be necessary, we're working around it:
libsigrok-internal.h:#define LIBUSB_CLASS_APPLICATION 0xfe
libsigrokdecode
---------------
- # Workaround for libusb not knowing LIBUSB_CLASS_APPLICATION
CFLAGS+= -DLIBUSB_CLASS_APPLICATION=0xfe
This is not correct and can be dropped, libsigrokdecode doesn't know
anything about USB at all.
sigrok-cli
----------
- freshports.org says "Required libraries: libserialport". Not sure what
exactly "required" means in this context, but sigrok-cli itself only
directly depends on glib, libsigrok and libsigrokdecode.
All other dependencies (libserialport, libusb, libzip, libftdi, libpython)
are indirect dependencies "inherited" via one of the libs.
sigrok-firmware
---------------
- This seems to be a meta-package depending on sigrok-firmware-fx2lafw
and sigrok-firmware-utils? There's also a sigrok-firmware repo with
some other firmware files, not all of them are "proper" open-source
licenses (some only allow redistribution, that's all).
http://sigrok.org/gitweb/?p=sigrok-firmware.git;a=summary
We'll make a sigrok-firmware-0.1.0.tar.gz release for those eventually,
I guess. Not sure if that will clash with your metapackage. Or can you
have it be both an actual package *and* a metapackage at the same time?
sigrok-firmware-fx2lafw
-----------------------
- Says "LICENSE=GPLv2". Not sure how this FreeBSD field works, but the
code contains both code that is "GPL, version 2 or later" as well as
code that is "LGPL, version 2.1 or later" (the overall license of the
resulting *.fw files is thus "GPL, version 2 or later").
sigrok-firmware-utils
---------------------
- This one is not yet released indeed, as you stated in
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=188808
We'll make a tarball with the firmware utilities (among others)
eventually, but that'll be named sigrok-util-0.1.0.tar.gz, matching
the repo name (and it will not only contain firmware-related utilities
but also others).
- "LICENSE=GPLv2". This is incorrect, all files you included are GPLv3+.
Cheers, Uwe.
--
http://hermann-uwe.de | http://randomprojects.org | http://sigrok.org
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
sigrok-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
