Hi Angus,

Thanks for your patch. It fixes the problem, so I will recommend it be 
merged.

As it happens this code is going to disappear within a day or two when 
Martin Ling merges his re-integration against the new libsigrok C++ 
bindings.

Still, thanks for fixing this. It was causing a problem for some of my 
own work I was doing on something else.

Thanks
Joel

On 07/10/14 23:47, Angus Gratton wrote:
> Hi Sigrok Developers,
>
> I noticed pulseview crashing when opening session files (definitely on
> the command line and I think when using File->Open). Seems the
> sequence of events causes File::create to clobber the existing
> _sr_session global when opening a session file (at least on my Debian
> Jessie setup).
>
> Attached patch changes that temporary session to be a temporary
> variable rather than the global session (more details in patch commit
> text).
>
> Thanks for all your hard work on sigrok!
>
>
> Angus
>
>
>
> ------------------------------------------------------------------------------
> Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
> Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
> Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
> Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
> http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
>
>
>
> _______________________________________________
> sigrok-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/sigrok-devel
>


------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
sigrok-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sigrok-devel

Reply via email to