On 10/04/2014 10:19 PM, Janne Huttunen wrote: Janne,
Sorry about the delay, forgot about this. > Since commit 5827f61b641cfd326a9cf2ea534eb4f9481a8187 > the config keys have capabilities associated with them. > I think '_GET' and '_SET' are more or less obvious, but > what are the intended semantics of the '_LIST' capability > supposed to be? These simply indicate whether the driver implements the config_get/_set/_list callback for that config key, or would return SR_ERR_NA for it. A client (or the library) could "probe" for this in theory, but that would be messy: you'd have to do it on all the channel groups and without one, and of course wildly calling config_set() on various keys is a little rash. Check the API docs on sr_config_set() -- the wrapper for these driver callbacks -- for more info on what SR_CONF_LIST means. > Also, how is sr_dev_has_option() supposed to work now? > As far as I can tell, currently it kind of doesn't, but > what are the intended semantics? Ouch! This was indeed broken, well spotted. I've fixed it now. > And finally, the commit log talks about updating the > SR_CONF_MASK if new bits are added. As far as I can see, > that mask is part of the ABI and if there is any remote > possibility that new bits will be needed, it might be > a better idea to reserve some extra bits in the mask now > before they are needed. That way there is at least some > chance that some "innocuous" bits could be defined there > in the future without breaking the ABI, right? You're right, this all makes SR_CONF_MASK part of the ABI. Not sure what else we'll need in there though -- get/set/list is all we've ever needed. -- Bert Vermeulen [email protected] email/xmpp ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk _______________________________________________ sigrok-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sigrok-devel
