Hi, On Wed, Oct 08, 2014 at 05:58:27PM +0200, Uwe Hermann wrote: > On Mon, Oct 06, 2014 at 11:50:52PM +0200, Johannes Römer wrote: > > this patch adds support for the single wire protocol used by the AM230x > > series of digital humidity and temperature sensors to libsigrokdecode. > > It was tested with a couple of AM2302, AM2303 and DHT11 devices. > > Sounds great, thanks a lot for your contribution! > > I'll do a quick review of the PD soonish, but can you please provide a > few test files for our sigrok-dumps repository in the mean time (as git > patch or pull request, or just as file attachment)? > > http://sigrok.org/gitweb/?p=sigrok-dumps.git;a=tree > > I can use those files for testing/reviewing the PD then, and ideally > we'd also like to make a small set of "unit tests" for this PD in the > (somewhat new) sigrok-test repository. See here for an example: > > http://sigrok.org/gitweb/?p=sigrok-test.git;a=tree;f=decoder/test/nrf24l01 > > It would be nice if you could also make a small test.conf file + outputs > for your PD (but if you don't have time or such we can do that as well > as long as you can provide some example *.sr files for sigrok-dumps).
I've actually found a DHT11 and AM2301 in one of my drawers that I totally forgot about, so I was able to test the PD :) The decoder is now merged, thanks again! I've done a few cosmetic changes and fixed two smaller issues (one timing change was needed for the sensors I had here apparently, not sure why). The AM2301 also seems to have a few more bits after the 40 initial ones (see dumps), haven't checked the datasheet as to what they mean yet. I added some example dumps from my two devices here: http://sigrok.org/gitweb/?p=sigrok-dumps.git;a=tree;f=am230x As mentioned above, it would be nice to get a few additional ones e.g. from an AM2302 and AM2303 etc. I haven't yet added test-cases in the sigrok-test repo, let me know if you want to work on that. A small wiki page for the decoder is up here: http://sigrok.org/wiki/Protocol_decoder:Am230x While I was testing all this, I couldn't resist to take the sensors apart as well, so if you're interested in PCB photos those are up too. Cheers, Uwe. -- http://hermann-uwe.de | http://randomprojects.org | http://sigrok.org ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://p.sf.net/sfu/Zoho _______________________________________________ sigrok-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sigrok-devel
