Hi,
On Fri, Feb 06, 2015 at 07:12:13PM +0100, Uffe Jakobsen wrote:
> Also adds small make/gmake adaption for FreeBSD
It would be better to fix (probably only) libsigrok's Makefile.am to not
require gmake, all the rest of sigrok (and 99% of libsigrok as well)
work fine with BSD make; this probably just needs a minor fix.
> With such a small change - I don't think that is serves any purpose
> to create a separate build script for FreeBSD
Agreed.
> +# Edit this to control verbose build output (VERBOSE=1)
> +VERBOSE=0
> +
> # Edit this to enable/disable/modify parallel compiles.
> PARALLEL="-j 2"
>
> @@ -51,6 +67,16 @@ PARALLEL="-j 2"
> P="$PREFIX/lib/pkgconfig"
> C="$C --prefix=$PREFIX"
>
> +MAKE_V_OPT="V=${VERBOSE}"
> +
> +# CMake generated makefiles uses VERBOSE switch to control verbose output
> +# The VERBOSE option itself enables the output mode - not its value
> +if test ${VERBOSE} -ne 0; then
> +MAKE_VERBOSE_OPT="VERBOSE=${VERBOSE}"
> +else
> +MAKE_VERBOSE_OPT=""
> +fi
No need for all this handling really, please just add "V=1" and
"VERBOSE=1" unconditionally in the script, that's also consistent
with the other cross scripts.
Uwe.
--
http://hermann-uwe.de | http://randomprojects.org | http://sigrok.org
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
