On Wednesday, April 29, 2015 03:27:29 PM Bert Vermeulen wrote:
> On 04/17/2015 08:38 PM, Alexandru Gagniuc wrote:
> > From: Alexandru Gagniuc <mrn...@google.com>
> > +                   else if (sr_atoi(s, &resp) == SR_OK)
> > +                           *gvar = g_variant_new_boolean(!!resp);
> 
> This seems overly broad. Note that the beeper commands are optional; they're
> only there because some hardware likes to beep on every received command,
> which gets old fast. Can you skip this?
I see. I added this because the Chroma 61604 beeps whenever the protection is 
tripped, and I thought that was what the SCPI_CMD_BEEPER meant. This made it 
convenient, as sigrok would clear a tripped protection when starting up.

We can skip this without losing much functionality in the subsequent patch.

Alex


------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel

Reply via email to