>
> options_[opt->id()] = def_val;
> -
> +
> const Property::Getter get = [&, opt]() {
> return options_[opt->id()]; };
> const Property::Setter set = [&, opt](VariantBase value) {
Please don't include any extraneous modifications.
> @@ -85,7 +85,7 @@ InputOutput::InputOutput(
> prop = shared_ptr<Property>(new Bool(name, get, set));
> else if (def_val.is_of_type(VariantType("d")))
> prop = shared_ptr<Property>(new Double(name, 2, "",
> - nullptr, nullptr, get, set));
> + boost::none, boost::none, get, set));
> else if (def_val.is_of_type(VariantType("i")) ||
> def_val.is_of_type(VariantType("t")) ||
> def_val.is_of_type(VariantType("u")))
>
We already have "using boost::none;" at the top of the file, so the line
should be:
none, none, get, set));
Otherwise, it looks like a helpful fix to have. Thanks for investigating
this.
Joel
------------------------------------------------------------------------------
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors
network devices and physical & virtual servers, alerts via email & sms
for fault. Monitor 25 devices for free with no restriction. Download now
http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
