Hi, On Fri, Nov 13, 2015 at 10:15:25AM +0100, Stefan Brüns wrote: > usb_signalling: consolidate symbol output > usb_signalling: detect bit stuffing errors > usb_signalling: remove unused ss_sop member > usb_signalling: remove unneeded syms array > usb_signalling: handle symbol errors in EOP state > usb_signalling: use explicit positions for packet start/end > usb_signalling: decode RESET and Keep-Alive signalling conditions > usb_signalling: add option to automatically set signalling speed
The patchset looks great, just a few questions / comments. self.putb([8, ['ERR', 'B']]) Is that 'B' there a typo, meant to be 'E' for error? For the ERR case, what is supposed to happen after such a condition with the PD? For some files/data it is now behaving differently. It no longer continues decoding further data, but rather stops emitting annotations upon the first ERR apparently. Is that intentional? You can see this happen e.g. in these files from sigrok-dumps: usb/hid/keyboard_mouse_combo/logitech_mk220/mk220_snippet.sr usb/hid/dmm/voltcraft_vc820/voltcraft_vc820_usb_err.sr Btw, sigrok-test will also need an update, I did this locally for testing (and then noticed the ERR behavior when looking at the diff): LD_LIBRARY_PATH=$HOME/sr/lib ./decoder/pdtest -r -v -f usb_packet usb_signalling Also, feel free to put the patches on github (or some other git hosting site) and just point to it, that makes things a bit simpler. Cheers, Uwe. -- http://hermann-uwe.de | http://randomprojects.org | http://sigrok.org ------------------------------------------------------------------------------ Go from Idea to Many App Stores Faster with Intel(R) XDK Give your users amazing mobile app experiences with Intel(R) XDK. Use one codebase in this all-in-one HTML5 development environment. Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs. http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140 _______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
