Hi Stefan, On Fri, 2015-11-27 at 00:50 +0100, Stefan Bruens wrote: > branch fix_memory_leaks
as Uwe said, great work. Glad to see someone investigate leaks using actual tools for the job. :) Some minor suggestions for next time: + g_ptr_array_free(ctx->channellist, 1); You can use TRUE rather than 1 here for clarity. GLib defines TRUE and FALSE in its headers if they aren't already defined. + g_variant_unref(options[0].def); + g_slist_free_full(options[0].values, (GDestroyNotify)g_variant_unref); Hm, options is a global static; so perhaps it would be prudent to also reset .def and .values to NULL here. But truth be told, I don't like the global static to begin with... Cheers, --Daniel ------------------------------------------------------------------------------ _______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
