Hi Bert,
> > + if (info->is_v_a_eff_value) {
>
> Might as well make this refer to RMS as well.Sorry, I'm not sure what you mean here. The variable name should be 'is_v_a_rms_value' maybe? > > > + analog->mqflags |= SR_MQFLAG_RMS; > > + analog->mq = SR_MQ_VOLTAGE; > > + analog->unit = SR_UNIT_VOLT; > > + /* TODO: Handle effective current value */ > > + // analog->mq = SR_MQ_CURRENT; > > + // analog->unit = SR_UNIT_AMPERE; > > Can you get rid of these TODOs and commented code? It's ok to leave it > unimplemented (open a bug about it maybe), but no need to litter the > code with TODOs. What is missing here is feeding back the values of the secondary display. Uwe had some ideas how to do this, and these are the sketches of it. I'd rather leave them in, so once sigrok (or this driver?) can handle returning two values, it will be easier for me to recall what is left to do (and I don't have to scan the includes for the proper values). > Or find a handy nearby source of AC current to test against :-) I'd love to, but I don't expect this to happen soon. So, I'd rather leave this as well, so people will know. Wolfram
signature.asc
Description: PGP signature
------------------------------------------------------------------------------
_______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
