Hello, I reseted my repository (https://github.com/zschunky/libsigrok.git) to setup everything via the new-driver script and adjusted the code fit to the coding style. The functional content there is almost the same compared to the initial version.
My next work items (whenever I find some time): - fill dev_acquisition_stop (currently stopping is not supported) - add trigger timestamp to data stream - add support for more trigger options (not yet sure how I gonna add this, since the provided trigger possibilities from sigrok do not fit to the hardware possibilities (2 different trigger setups, both of them can be combined via or/and, possibility of selecting digital ranges, possibility of specifying time restrictions for trigger values)) -> my current idea is to add an optional config file just for this driver - try to optimize the usb packet handling and its state machine behind - add possibility to set threshold voltage (my first try failed) -> is this even possible in sigrok for logic analyzers? best regards -Andreas On 02/28/2016 10:36 PM, Uwe Hermann wrote: > Hi, > > On Wed, Feb 24, 2016 at 09:58:35PM +0100, Andreas Zschunke wrote: >> I added support of the Hantek 4032l logic analyzer to the libsigrok >> library. The source can be pulled or used from: >> https://github.com/zschunky/libsigrok.git > Thanks a lot for working on this! > > >> This is the 1st version of the implementation. I will continue to clean >> it up and advance it. For now only one stage of triggers is supported >> with only one channel being rising/falling/edge. All other channels can >> still be used as trigger with 0 or 1. The threshold voltage is currently >> fixed to 1.5V. Sample size per channel ranges from 2kb to 64Mb in 512 >> byte steps (given size will be adjusted if it does not fit into 512 byte >> steps). >> >> Feel free to try it out. Feedback and code review is welcome (it was my >> first time I had to deal with sigrok code and libusb). > Just a few basic points to make future reviews easier, could you please > fix the following things: > > - Please use the "new-driver" script from our sigrok-util repo to generate > the initial driver framework (api.c and protocol.[ch]). Keep that > generated patch as the first commit, and add your actual > implementation on top of that as a second commit. The libsigrok API > calls go into api.c, the other stuff (protocol implementation) into > protocol.c usually. > > - Please use the same coding style as in the rest of the sigrok > code-base, i.e. one tab for indentation, foo_bar() function names > instead of camel-case or similar, #defines and enums are UPPER_CASE etc. > We're basically using the Linux kernel conventions mostly, see HACKING. > > - Once you're done with a first version of the driver please drop all > the obsolete (commented out) debug code and such so that we can > commit a first clean version to the upstream repo. The driver doesn't > have to fully support all features yet for that, but the code that > gets in should be reasonably clean. > > Other than that the code looks pretty promising, please let us know when > the next iteration is ready for review/testing. > > > Cheers, Uwe. ------------------------------------------------------------------------------ _______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
