On 08/07/2016 09:53 PM, Mike Meyer wrote: > As noted earlier, the sigrok-cli command outputs analog values that the > output module chooses not to output for some reason, like that channel is > disabled. The comment says this should happen if the user didn't specify an > output module, which is not quite what the code implements. The current > behavior is annoying and confusing, whereas the behavior implied by the > comment would be neither. > > This behavior was added in commit 9216694f9278c653c2567074d3d0546d62390ca3, > and even then the code and comment didn't match. The commit message doesn't > explain why the comment and code behave differently, so I'm guessing it was > a bug.
What that patch does is fix the default behavior when no preferred output format was specified. It used to display only logic (defaulting to bits64), and adds analog output as well if that shows up. You're deleting the part where it uses the analog output module as a backup iff there was no output module specified (i.e. default bits64 was used), and iff nothing was therefore output, and iff this concerns an analog packet. -- Bert Vermeulen [email protected] ------------------------------------------------------------------------------ _______________________________________________ sigrok-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sigrok-devel
