Hi Vladislav, function generators should definitely be supported. Not just to be able to control them but also for the killer feature of being able to play back a captured signal (circuit -> scope -> sigrok -> arbitrary waveform signal gen -> circuit).
From my point of view, supporting every single option might be overkill, however. If my signal generator had a usable interface, I'd use it to easily configure mode, frequency, amplitude, offset and sweep. Then I'd be happy already. On the other hand, configuring even rarely used options via one single sigrok-cli command line certainly has its benefits, too. That makes me wonder whether the architecture with fixed SR_CONF_* keys (and only those) is too rigid. We've kinda had the discussion before and it would certainly be doable to have SR_CONF_* keys that can be registered by drivers at runtime. That way, the SR_CONF_* table won't explode from adding tons of really custom stuff and because libsigrok clients can list all options, they can still support everything. Definitely doable, just needs a bit of work to make it happen as the current structures are static (e.g. arrays). Any more opinions? Uwe? All the best, -Soeren On 2016-10-26 03:14, Vladislav Ivanov wrote: > Hello, > > I have Rohde&Schwarz signal generator at work which can be controlled > over a serial port. I was wondering whether or not it would be > appropriate to integrate it into libsigrok. RF signal generators have a > lot of controls that aren't present in the SR_CONF_* options list, like > modulation mode, modulation source and polarity, FSK deviation > frequency, etc. Should sigrok support this kind of devices? > > Regards, > > Vlad Ivanov > > ------------------------------------------------------------------------------ > The Command Line: Reinvented for Modern Developers > Did the resurgence of CLI tooling catch you by surprise? > Reconnect with the command line and become more productive. > Learn the new .NET and ASP.NET CLI. Get your free copy! > http://sdm.link/telerik > _______________________________________________ > sigrok-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/sigrok-devel ------------------------------------------------------------------------------ The Command Line: Reinvented for Modern Developers Did the resurgence of CLI tooling catch you by surprise? Reconnect with the command line and become more productive. Learn the new .NET and ASP.NET CLI. Get your free copy! http://sdm.link/telerik _______________________________________________ sigrok-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sigrok-devel
