On Wed, Nov 02, 2016 at 20:39 +0100, Gerhard Sittig wrote:
>
> Hi!
>
> When I looked at several places in the sigrok's subprojects'
> sources, I noticed the absence of common endianess conversion
> helpers. All affected call sites appear to open code the
> respective functions.
This was written from the top of my head. Apparently I was
exaggerating. :)
Doing the recursive search for WORDS_BIGENDIAN across several
repos, one can see that strictly only libsigrok is affected, and
it's just a few spots: analog data handling, tests for analog
data, WAV input and output modules, Saleae logic analyzer driver,
C++ binding.
These are the spots which reference the endianess as it was
detected by autoconf. Haven't checked how much further the
effect goes that depends on derived information (stored condition
variables which later influence other code paths). And haven't
looked for locations which handle endianess but don't reference
the WORDS_BIGENDIAN condition.
Still it might be worth to factor out the endianess handling.
Asix Sigma (WIP) is a current motivation. Other locations could
benefit from common logic.
virtually yours
Gerhard Sittig
--
If you don't understand or are scared by any of the above
ask your parents or an adult to help you.
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
