On Mon, Nov 28, 2016 at 14:50 +0100, Matthieu Guillaumin wrote:
>
> - The memory is a sequence of recordings that start with a header
> (containing some flags and a timestamp). This timestamp is obviously a
> very important piece of information about past recorded measurements,
> but I haven't found any way to provide them to the sr_session_send()
> function. Right now I can only print the timestamps on stderr using
> something like sr_info(), so it's pretty lame, since stderr and stdout
> need not be synced. Do you have any suggestion on how to handle this
> before I submit a patch?
As I understand it, sigrok uses a stream of sample data which is
said to have a specific samplerate. Times are the consequence of
watching a number of samples pass by at their specified rate. If
you have a timestamp in your input from the device, you may have
to provide "padding" samples until the specified time is due.
For example, the Asix Sigma logic analyzer repeats the last
provided sample in that case (see the sigma_decode_dram_cluster()
routine).
> - I still haven't fully figured out all the semantics of the header
> flags. Is it ok to submit a patch with only partial support?
> (currently, it only supports the dBA/dBC flag of recordings, not fast
> vs. slow nor measurement ranges)
I'd guess that when a patch clearly fixes something, or adds
something new, then it's OK. As long as the patch in itself is
consistent and correct. When there is more to explore, it can
get added later in yet another patch. You can "queue" TODO items
or unfinished stuff in your local repo as much as you like, git
is good at this. :) Feed submissions upstream as they complete.
Choose your own pace at that.
> - Experimenting with my pce-322a device has unearthed some minor
> differences with what is currently described on the wiki page [*]. I'd
> be happy to update the page if you gave me an account. It could be
> interesting to see if the differences are due to variations of the
> model or incomplete reverse-engineering by the original author (in
> CC).
You can "/MSG sigbot help wiki" on IRC to learn how to create
your account.
virtually yours
Gerhard Sittig
--
If you don't understand or are scared by any of the above
ask your parents or an adult to help you.
------------------------------------------------------------------------------
_______________________________________________
sigrok-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
