Hi Marchel, the manual way is perfectly fine, too. We just want the addition of the driver and the creation of the (almost) empty files in a separate commit.
If you push the changes to your own github account then we'll review it and give feedback. If it's good to go then Uwe will pull from there. All the best, -Soeren On 2016-12-19 04:14, Marchel Hooijboer wrote: > Hi Soeren, > > Thanks for the information, i have not used the script yet, but will > create a new git checkout and try again. Problem was that the script > was throwing an error and thus I used the manual procedure as described > in the readme file. For direct development I will use a github repo, > where I push mij code to. Are you pulling from there then into the > libsigrok repo than? > > Gr, > Marchel. > > Op ma 19 dec. 2016 10:06 schreef <soe...@apelpie.net>: > >> Hi Marchel, >> >> thanks for wanting to contribute! >> >> For new drivers, there are two preferable ways: >> 1) push the changes to your personal github repo >> 2) send the changes to the mailing list >> >> You can pick whichever you prefer. However, you should know >> that two things are expected: the initial commit should contain >> nothing but the changes made by the sigrok-util/source/new-driver >> script. The commits after that can then populate the files with code. >> The second thing that we expect is that you put your own >> name in the copyright notice. We want to give proper credit :) >> If you took code from others then of course they should receive >> proper credit, too. Is the code you took compatible with GPL3? >> >> All the best, >> >> -Soeren >> >> On 2016-12-19 01:56, Marchel Hooijboer wrote: >> >>> Hi there, >>> >>> I'm currently busy writing the hardware drivers for the Siglent >>> SDS1000 >>> and 2000 series scopes to libSigrok. The device selection(network) is >>> working and basic setup of the device works as well. The basic >>> waveform >>> acquisition is also starting to work. The complete series should wok >>> with this implementation such as the CML/DL and CNL version and the >>> latest X and X+ versions. Thus in regards to the X+ versions I'm >>> planning to add the logic analyzer support to. I hope that there are >>> some beta testers that actually own a older model, because I only own >>> a >>> SDS1000X+ device. >>> >>> That brings me to a question, how do I proceed with publishing my >>> beta >>> stage code to the main stream code brange? My base work is based on >>> the >>> Rigol DS1000 series implementation I have asked permission to these >>> developers and there was no issue in using there code as a starting >>> point. >>> >>> Kind regard, >>> Marchel Hooijboer. >>> ------------------------------------------------------------------------------ >>> Check out the vibrant tech community on one of the world's most >>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot >>> _______________________________________________ >>> sigrok-devel mailing list >>> sigrok-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/sigrok-devel ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
