Hi, On Tue, Nov 22, 2016 at 12:20:07PM +0000, Martin Ling wrote: > What I suggested instead is that we move the serial-over-HID support > into libsigrok's own serial layer (serial.c). This does still exist, > although it is now largely just a compatibility wrapper around > libserialport. We use this wrapper consistently - I've just looked and > the only place where a libsigrok driver currently calls libserialport > directly is in the OLS driver, where it calls sp_input_waiting() a > couple of times. So it would be a relatively easy change. > > If we add the serial-over-HID support to the serial.c layer, then the > uni-t-dmm driver could just be merged into the serial-dmm driver, with > the chipset support separated in the normal way. We'd eliminate the > "-ser" suffixed sub-drivers for UNI-T DMMs, these would just be the same > driver used with a different connection specified by SR_CONF_CONN.
Yup, agreed, this seems like the best solution for multiple reasons. There was a similar bug (avoiding the duplication in uni-t-dmm and serial-dmm) open as #251 already, I've added some more info there. Patches to implement the move to serial.c and then merge uni-t-dmm into serial-dmm are highly welcome! I can provide testing on various serial and USB/HID based DMMs, and I also have a UT612 by now that I can test. Uwe. -- http://hermann-uwe.de | http://randomprojects.org | http://sigrok.org ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/intel _______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
