On Sat, Feb 18, 2017 at 13:05 +0100, Matthieu Guillaumin wrote:
>
> Dear all,
>
> I submitted this patch for review early December, adding support for
> reading the memory of PCE-322A devices. If I'm not mistaken, I didn't
> get any response yet.
>
> https://github.com/mguillau/libsigrok/commit/8cc328fdee3f98ad7ae85e1e2cc57f947bb3f6e9
>
> Thanks in advance for your comments,
> Matthieu
Maybe it's not just about getting feedback on a specific
implementation. IIUC questions were raised about semantics and
how to most appropriately handle the device's data.
Here is what I remember, correct me where I'm wrong.
- The device in question can record a set of samples, and can do
so multiple times.
- So you end up with memory content that has multiple samples
where some of them form a sequence and others are not related
to the other samples or sequences.
- Inserting lots of padding between "sessions" can be considered
"as artificial, and probably inappropriate" as inserting random
values. Either approach has to determine a value that cannot
be mistaken for a valid sample. And neither approach correctly
represents what the device has recorded.
The best mental model I could come up with is reading the memory
content of the device, and exporting adjacent samples to one
session each, creating as many sessions as the device has
recorded. Yet that's quite different from other devices and
their data streams, as I understand it. The current driver model
of sigrok may not lend to this situation, and some other hack
around it might be required. It needs to be well understood how
any approach will be a hack, and why it was necessary.
Did I miss something? Can you summarize your reasoning and how
you addresses the concerns that you had? Having those questions
and decisions documented somewhere probably has a lot of value,
such that the next person won't come along and "fix/improve" the
implementation which was done in a specific way for very good
reasons ...
I did happen to provide some feedback, but honestly don't have an
answer for you. And I felt that code review requires choosing an
approach before, after the device's semantics is understood.
That's why I will go silent again on this thread.
virtually yours
Gerhard Sittig
--
If you don't understand or are scared by any of the above
ask your parents or an adult to help you.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
