Hi all,

Can the gnuplot output format be brought back please? The git log says that
it was removed because it is obsoleted by improved CSV output module, but
CSV output module has been broken for quite a while now. See this, for
example http://sigrok.org/bugzilla/show_bug.cgi?id=844

I tried using CSV through VCD as a workaround, but simple command

sigrok-cli -I vcd -i VCDFILE -O csv:gnuplot -o GNUPLOTFILE

segfaults too.

I tried digging into it and while the error in -I VCD -O csv:gnuplot case
seems obvious, i.e. this line here

http://sigrok.org/gitweb/?p=libsigrok.git;a=blob;f=src/output/csv.c;h=c39c29a7378fe9cd935fbaff0f35f2255f548f2a;hb=HEAD#l385

should probably be

- ctx->channels[i].label = "logic";
+ctx->channels[j].label = "logic";

the change does not really fix the output, sample number in the output are
all zeroes.

Anyway, I think it makes sense bringing back gnuplot output until CSV
stabilizes.

I tried with the head and simply reverting this commit
http://sigrok.org/gitweb/?p=libsigrok.git;a=commit;h=f9c6b5cfd3c0f6cb737f6a68f69034ce6819f36d

works just fine.

Thank you.

--
Maxim Sloyko
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel

Reply via email to