Hi, On Thu, May 11, 2017 at 01:51:06PM +0200, Wolfram Sang wrote: > Motivated by bug #844 and the further report by Maxim Sloyko, I checked > process_input() for problems and found a few with valgrind and by code review.
Merged, thanks a lot! I mentioned the bug number in the commit msgs for easier reference. > The code seems to need broader testing; does sigrok have test cases for > input/output modules? Couldn't find anything... Not yet, but it's on out wishlist indeed. We need something similar to the test specs and result files we currently have for protocol decoders. In sigrok-test that'd be in a separate "format" directory, using something similar to runtc/pdtest (or extending those), maybe even calling sigrok-cli directly, though the first option is probably preferable. This would be really useful for all input/output formats (csv, vcd, sr, wav, ols, la8 and many more) to track/avoid/fix regressions indeed. Patches welcome :) Uwe. -- http://hermann-uwe.de | http://randomprojects.org | http://sigrok.org ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
