On Wed, Jun 28, 2017 at 07:06 -0500, Richard Allen wrote:
>
> From 350810d3b7eb82b775b33b3b9e63a387354b88d2 Mon Sep 17 00:00:00 2001
> From: Richard <rsa...@rsaxvc.net>
> Date: Wed, 28 Jun 2017 00:23:35 -0500
> Subject: [PATCH 2/2] Add support for sparkfun 70C to serial-dmm
>
> sparkfun-70c-ser
> ---
> src/hardware/serial-dmm/api.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/hardware/serial-dmm/api.c b/src/hardware/serial-dmm/api.c
> index e39480e9..5b04e5dc 100644
> --- a/src/hardware/serial-dmm/api.c
> +++ b/src/hardware/serial-dmm/api.c
> @@ -414,6 +414,12 @@ SR_REGISTER_DEV_DRIVER_LIST(serial_dmm_drivers,
> sr_fs9922_packet_valid, sr_fs9922_parse, NULL
> ),
> DMM(
> + "sparkfun-70c-ser", fs9922,
> + "Sparkfun", "70c", "2400/8n1/rts=0/dtr=1",
> + 2400, FS9922_PACKET_SIZE, 0, 0, NULL,
> + sr_fs9922_packet_valid, sr_fs9922_parse, NULL
> + ),
> + DMM(
> /*
> * Note: The VC830 doesn't set the 'volt' and 'diode' bits of
> * the FS9922 protocol. Instead, it only sets the user-defined
Please keep the sort order of the DMM entries. Thank you! See
the comment at the top of the table.
The subject line suggests the name is "70C", while the patch
declares "70c" in the user visible strings. Please stick with
one capitalization for the product, ideally what the vendor uses.
BTW "SparkFun" itself uses a capital inline F for their company
name, too.
I know about this since I was the one who misspelled PeakTech, as
well as the one who did sort the table in the first place. :)
virtually yours
Gerhard Sittig
--
If you don't understand or are scared by any of the above
ask your parents or an adult to help you.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
