The current starting index for the POD name in the hameg-hmo driver is currently wrong as it is zero.
The official POD numbering starts instead at 1 (see device panel, buttons and manual), so the current index used for message printing and groups naming in the driver needs to be incremented by one. Signed-off-by: Guido Trentalancia <gu...@trentalancia.com> --- src/hardware/hameg-hmo/protocol.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -pru libsigrok-git-orig/src/hardware/hameg-hmo/protocol.c libsigrok-git-hameg-hmo-pod-starting-index/src/hardware/hameg-hmo/protocol.c --- libsigrok-git-orig/src/hardware/hameg-hmo/protocol.c 2018-11-16 00:17:05.993415671 +0100 +++ libsigrok-git-hameg-hmo-pod-starting-index/src/hardware/hameg-hmo/protocol.c 2018-11-16 21:40:42.602797385 +0100 @@ -404,11 +404,11 @@ static void scope_state_dump(const struc for (i = 0; i < config->digital_pods; i++) { if (strncmp("USER", (*config->logic_threshold)[state->digital_pods[i].threshold], 4)) - sr_info("State of digital POD %d -> %s : %s (threshold)", i, + sr_info("State of digital POD %d -> %s : %s (threshold)", i + 1, state->digital_pods[i].state ? "On" : "Off", (*config->logic_threshold)[state->digital_pods[i].threshold]); else // user-defined or custom logic threshold - sr_info("State of digital POD %d -> %s : %E (threshold)", i, + sr_info("State of digital POD %d -> %s : %E (threshold)", i + 1, state->digital_pods[i].state ? "On" : "Off", state->digital_pods[i].user_threshold); } @@ -882,7 +882,7 @@ SR_PRIV int hmo_init_device(struct sr_de ret = SR_ERR_MALLOC; break; } - devc->digital_groups[i]->name = g_strdup_printf("POD%d", i); + devc->digital_groups[i]->name = g_strdup_printf("POD%d", i + 1); sdi->channel_groups = g_slist_append(sdi->channel_groups, devc->digital_groups[i]); } _______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel