On Samstag, 17. November 2018 17:37:39 CET Guido Trentalancia wrote: > Bug #1329 has now been opened: > > https://sigrok.org/bugzilla/show_bug.cgi?id=1329 > > Anyone can test the current udev rule that you wrote and easily realize > that it triggers the bug, as explained in the bug report and in this > thread. > > It leads to *device opening failures*, therefore users are not able to > use sigrok and libsigrok !
Nobody denies non-world read/writable device permissions leads to opening failures when opening is tried by someone not granted permission. Denying access is the very point of access permissions. The rules distributed by libsigroks covers a broad range of distributions and scenarios: 1. For distributions using logind (or one of its compatible replacements, e.g. elogind), access is granted for users having a local session. 2. For Debian based distributions, the plugdev rule is included, granting access based on group membership. The plugdev rule can easily be adapted to local needs, using a different group, and placing it in /etc/udev/rules.d/. Your patch removes any access control to the devices. This can be a significant security problem, as the rules also cover other devices connected using usb-serial converters, like braille devices. Regards, Stefan -- Stefan Brüns / Bergstraße 21 / 52062 Aachen home: +49 241 53809034 mobile: +49 151 50412019
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
