Hi Uwe,

Thanks for the merge! Also thanks for maintaining Sigrok – it's been a
great tool for me!

I'm not sure why the file claims 1GHz sample rate. I'm pretty certain that
I collected it with 50MHz rate. Also my equipment only goes up to 400MHz,
so 1GHz would not be possible.

Thanks!

Best,
Jiahao

On Tue, May 14, 2019 at 5:37 PM Uwe Hermann <u...@hermann-uwe.de> wrote:

> Hi,
>
> On Wed, Feb 20, 2019 at 06:35:08PM -0500, Jiahao Li wrote:
> > Hi Sigrok devs,
> >
> > Here I have attached two patches (to libsigrokdecode and sigrok-dumps,
> > respectively) implementing a decoder for the Microchip ENC28J60 SPI
> > Ethernet chip. It's my first time contributing to Sigrok, so please let
> me
> > know if I have missed anything.
>
> The decoder looks great, thanks a lot! Sorry for the delay. Merged now with
> a few changes on top, mostly minor cosmetic stuff.
>
> I also added a test-case to the sigrok-test repo.
>
> The *.sr file in sigrok-dumps claims to be 1GHz samplerate, the README
> says 50MHz though, that seems a bit strange (?)
>
>
> Cheers, Uwe.
> --
> http://hermann-uwe.de | http://randomprojects.org | http://sigrok.org
>
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel

Reply via email to