Hello,
Thanks a lot for coming my way. Today it was confirmed to me that I
can't post any material from this work online.
If you want I could buy blank cards myself and sniff in the future,
so that you don't need to buy a reader for this sole purpose.
I've fixed the unused variable and the case issue on github.
Thanks a lot for spotting them!
If you confirm I can post the sniffs later on, I'll proceed with the
pull request.
Thanks,
On 2019-12-15 23:51, Uwe Hermann wrote:
Hi,
On Sun, Dec 15, 2019 at 05:47:46PM +0100, Federico Cerutti wrote:
Hello,
I have written a simple protocol decoder for the Siemens/Infineon SLE
4418/28/32/42 memory card family.
You can check it out here: https://github.com/ceres-c/SLExx-Sigrok
I'm writing this email to ask if it would be possible get the decoder
in
Sigrok without a sniff or if someone else could, maybe, sniff another
system
using this kind of cards. Unluckily, I can't post my own sniffs
because I
have signed a NDA about the system.
We usually prefer to have .sr files and some tests in the sigrok-test
repo for regression testing etc., but in this case I think we can make
an exception, yeah.
It seems it's easy enough to get reader hardware and some blank SLE4442
cards from ebay, so I can probably grab a few sample captures later...
Of course I'm open to suggestions/scoldings about my current code.
Upon a quick look, the decoder looks fine, please send a GitHub pull
request (https://github.com/sigrokproject/libsigrokdecode).
Minor comments: The "id" and "outputs" values should be all-lowercase,
directory name of the PD should be "sle44xx" as well. self.out_bitrate
looks unused, can be dropped.
Cheers, Uwe.
--
Federico Cerutti
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
