Hello Panu-Kristian,
Thanks for contributing and the write-up!
While I'm not an expert myself and thus can't comment on your
implementation,
I do have one remark:
As your screenshot shows, a user will only know that something's fishy
if he
or she pays close attention to the annotations.
I would prefer if the user would get a visual indication that something
is going
on. Other PDs have a special annotation row and class that they use for
such
things, usually called "Warning".
When the sdcard_sd PD detects the condition that you fixed, I would
expect an
annotation to appear in a "Warning" row.
Do you feel like this is something you can add?
All the best,
-Soeren
On 2020-01-10 03:51, panu-kristian.poiks...@vlsi.fi wrote:
Hi!
Here's an error condition robustness update for SD Card (sdcard_sd)
protocol analyzer. It adds recovery from state machine failures caused
by
missing packets, which would make the decoder show replies as commands
and
commands as replies, which was a common annoyance in my debug traces.
For more information and screenshots, please visit:
https://imgur.com/a/TeVnzR3
Sincerely,
Panu-Kristian Poiksalo,
Chief IC Application Engineer, VLSI Solution Oy
Disclaimer: I'm a wizard with hardware, but not so much with Python, so
please take this as it's offered: with a pure heart and good
intentions.
It's as simple as I could make it, but I have no doubt that any one of
you
guys could make it better, and that would be great. But for me, my
three
simple additions into the decoder made a huge difference for me in
finding
where my errors in the VSOS SD card driver were.
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
